I noticed my editorAlias is actually tooorangey.EditorNotes.v8 (specific attention to the .v8 at the end).
I used the Replace() method, and when that didn’t have an affect I went the more direct route and used Remove().
I believe this editor hasn’t changed but for some reason in my current environment it does have a different editor alias. I could probably open a PR to add this to the existing one but I wanted to make sure this worked first. I must be getting hung up on the simplest thing.
My composer is hit and in the screenshot I am just being explicit about removing both the default and optional composers that are already part of uSync Migrations…
To make all of this more confusing for us, if I remove my copy of the migrator (just a copy of one out of your project) and I remove both of yours (handling tooorangey.EditorNotes), I get the exact same result. As if something in the migration is still converting tooorangey.EditorNotes.v8 to Umbraco.Community.Contentment.EditorNotes for content types but not touching the data type.
I think I need to take a break from coding this weekend…